Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: update builtin cert bundle for 0.12 #10261

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tls

Description of change

Copied certdata.txt from master, rebuilt header using mk-ca-bundle.pl.

Fix #7962

Copied certdata.txt from master, rebuilt header using mk-ca-bundle.pl.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tools Issues and PRs related to the tools directory. v0.12 labels Dec 14, 2016
@sam-github
Copy link
Contributor Author

/to @nodejs/lts If you want it, here it is.

/cc @bnoordhuis In case I did something wrong, but it seems pretty straighforward.

@sam-github sam-github added tls Issues and PRs related to the tls subsystem. lts-watch-v0.12 labels Dec 14, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 14, 2016

Is it even worth merging anything v0.12-related at this point? I doubt there will be another v0.12 release before the end of the this month.

@sam-github
Copy link
Contributor Author

@mscdex I don't know, but @jasnell and @silverwind indicated they thought so. I'm just trying to close out tls/crypto bugs, if we can just close #7962 as "won't do", that's good, too.

@Fishrock123
Copy link
Contributor

I don't think we ended up ever doing the previously scheduled 0.12 release... So I think there will still be one, maybe next week? It was on @rvagg's plate and I can bug him about it again.

@bnoordhuis
Copy link
Member

bnoordhuis commented Dec 14, 2016

Sam, did you check what certificates have been added and removed? It looks like the last update was three (!) years ago, the changeset is probably quite extensive; possibly quite disruptive too for a final release.

EDIT: It's, marginally, less bad than I originally thought. The commit date is November 2013 but the certdata.txt is actually from November 2014. Ain't git wonderful?

@sam-github
Copy link
Contributor Author

No, I just made 0.12 support the same as master.

I think leaving 0.12 alone is probably best. This can be reopened if someone feels strongly.

@sam-github sam-github closed this Dec 14, 2016
@sam-github sam-github deleted the update-v0.12-certdata branch December 14, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants