Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage-linux workflow going out of memory #39445

Closed
targos opened this issue Jul 19, 2021 · 4 comments
Closed

coverage-linux workflow going out of memory #39445

targos opened this issue Jul 19, 2021 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@targos
Copy link
Member

targos commented Jul 19, 2021

/~https://github.com/nodejs/node/runs/3103690697?check_suite_focus=true
/~https://github.com/nodejs/node/runs/3102905499?check_suite_focus=true
@targos targos added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 19, 2021
@targos
Copy link
Member Author

targos commented Aug 3, 2021

/~https://github.com/nodejs/node/runs/3231046711?check_suite_focus=true

@targos
Copy link
Member Author

targos commented Aug 4, 2021

/~https://github.com/nodejs/node/runs/3238780429?check_suite_focus=true

@bcoe

@bcoe
Copy link
Contributor

bcoe commented Aug 5, 2021

I think perhaps we just need to pass a larger --max-old-space-size=8192 to c8, it merges 1000s of coverage reports together, from each subprocess, and my hunch is that we're bumping into memory limits for the combined object.

@bcoe bcoe mentioned this issue Aug 6, 2021
Closed
@bcoe
Copy link
Contributor

bcoe commented Aug 15, 2021

@targos I believe we've fixed this?

@bcoe bcoe closed this as completed Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: increase memory for coverage action bcoe/node-1
2 participants
@bcoe @targos