Replace endian specific copy functions with DataView #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #13 (comment)
@guybedford This is the tidied up version of the hack I did to get the tests passing on AIX (big endian). I'm okay with #13 so am not fussed if this lands or is just closed out, but I've opened it anyway as an FYI.
FWIW the original hack kept the
copyBE
andcopyLE
functions and only usedDataView
forcopyBE
. It was hacky because it took me a while to realise that the source length was in characters and DataView's length/offsets were in bytes.