Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit AppVeyor use #3089

Closed
2 tasks
nlohmann opened this issue Oct 17, 2021 · 4 comments
Closed
2 tasks

Limit AppVeyor use #3089

nlohmann opened this issue Oct 17, 2021 · 4 comments
Labels
state: help needed the issue needs help to proceed

Comments

@nlohmann
Copy link
Owner

nlohmann commented Oct 17, 2021 •
edited
Loading

Check if all jobs in AppVeyor are needed. AppVeyor is much slower as GitHub Actions.

  • Remove jobs that can also be executed in GitHub Actions.
  • Adjust README file.
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Jan 9, 2022
@nlohmann nlohmann removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Mar 7, 2022
@falbrechtskirchinger
Copy link
Contributor

Differences I'm noticing:

  • Tests Visual Studio versions not available in GitHub runners. (2015 and 2017[1])
  • Injects #include <windows.h> into json.hpp.
  • Possibly minor differences in CXXFLAGS, e.g.
    /Zc:__cplusplus Enable the __cplusplus macro to report the supported standard (off by default).

[1] Visual Studio 2017 support ends March 15th: actions/runner-images#4312

@nlohmann nlohmann added the state: help needed the issue needs help to proceed label Mar 7, 2022
@nlohmann
Copy link
Owner Author

nlohmann commented Mar 7, 2022

I did not know that GitHub would drop Visual Studio 2017 support - thanks for letting me know. If there are no hosted images - is anyone aware of Docker images to use instead?

@nlohmann
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: help needed the issue needs help to proceed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @falbrechtskirchinger