fix: x-forwarded-proto is sanitized now #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
commented
Aug 24, 2022
src/index.ts
Outdated
| @@ -30,6 +32,8 @@ export function createIPXHandler ({ | |||
| } | |||
| const handler: Handler = async (event, _context) => { | |||
| const host = event.headers.host | |||
| event.headers['x-forwarded-proto'] = X_FORWARDED_PROTO_VALUES.includes(event.headers['x-forwarded-proto'].toLowerCase()) ? event.headers['x-forwarded-proto'] : 'http' | |||
There was a problem hiding this comment.
Now we only allow the allowed values for x-forwarded-proto.
dustincrogers
previously approved these changes
Aug 24, 2022
nickytonline
commented
Aug 24, 2022
src/index.ts
Outdated
| @@ -30,7 +30,7 @@ export function createIPXHandler ({ | |||
| } | |||
| const handler: Handler = async (event, _context) => { | |||
| const host = event.headers.host | |||
| const protocol = event.headers['x-forwarded-proto'] || 'http' | |||
| const protocol = event.headers['x-nf-connection-proto'] || 'http' | |||
There was a problem hiding this comment.
@mraerino mentioned this as a better option as it can't be tampered with.
This reverts commit abfbff4.
mraerino
reviewed
Aug 24, 2022
Co-authored-by: Marcus Weiner <marcus.weiner@gmail.com>
mraerino
reviewed
Aug 24, 2022
mraerino
previously approved these changes
Aug 24, 2022
nickytonline
force-pushed
the
nickytonline/x-forwarded-proto-fix
branch
from
3cc3032 to
16c154e
Compare
mraerino
approved these changes
Aug 24, 2022
dustincrogers
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where someone can inject a non-standard value in the
x-forwarded-protoheader.Related Issues and Documents
/~https://github.com/netlify/pod-ecosystem-frameworks/issues/208