fix: casing now matches what comes in a Netlify function via event.headers #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
nickytonline/fix-waf-bypass-token-header-casing
branch
from
dfaeffb to
537093c
Compare
hrishikesh-k
deleted the
nickytonline/fix-waf-bypass-token-header-casing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; when I tested this last week, I think something was cached giving the impression that my fix worked. I'm still uncertain how things got cached in a way that led me to think it was fixed on a test site of mine, but here's the rest of the fix.
When we handle headers the casing doesn't matter in other parts of our infrastructure, but it appears that headers get normalized to all lowercase names. Not sure why I didn't catch this (hat tip @hrishikesh-k for suggesting this), but I guess it's been a busy couple of weeks. 😅
To test this, it really requires the Next.js runtime using the version of
@netlify/ipxonce this gets merged. I've tested it with a release candidate,@netlify/plugin-nextsjs@4.39.4-rc-waf-fix-0.0.0on my test site https://nick-waf-ipx-test.netlify.app/, Note that you will receive a 404 if you go to the site. You will need to add your IP to the list of allowed IPs. I can configure this if you'd like to test it.Relates to /~https://github.com/netlify/pod-ecosystem-frameworks/issues/592