Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error or missing configuration items #76

Closed
jeremystretch opened this issue Sep 5, 2024 · 0 comments · Fixed by #78
Closed

Raise error or missing configuration items #76

jeremystretch opened this issue Sep 5, 2024 · 0 comments · Fixed by #78
Assignees
@jeremystretch
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Contributor

Proposed Changes

Raise an exception on init if either of the following conditions is not met:

  • settings.DATABASES must be a DynamicSchemaDict instance.
  • DATABASE_ROUTERS must include the path to BranchAwareRouter

Justification

Without both of these configuration items, branching will not function correctly.
@jeremystretch jeremystretch added the type: housekeeping Changes to the application which do not directly impact the end user label Sep 5, 2024
@jeremystretch jeremystretch self-assigned this Sep 5, 2024
@netboxlabs netboxlabs deleted a comment Sep 5, 2024
jeremystretch added a commit that referenced this issue Sep 5, 2024
@jeremystretch
Closes #76: Check for required settings on init
12dc0ae
@jeremystretch jeremystretch mentioned this issue Sep 5, 2024
Merged
@jeremystretch jeremystretch mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #76: Check for required settings on init netboxlabs/netbox-branching
1 participant
@jeremystretch