Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging a branch should default to performing a dry run #15

Closed
jeremystretch opened this issue Jul 22, 2024 · 2 comments
Closed

Merging a branch should default to performing a dry run #15

jeremystretch opened this issue Jul 22, 2024 · 2 comments
Assignees
Labels
type: feature A new feature or functionality

Comments

@jeremystretch
Copy link
Contributor

Plugin Version

v0.2.0

Proposed functionality

The "merge branch" confirmation dialog (pictured below) currently commits by default.

screenshot

This FR proposes rendering this checkbox as unchecked initially.

Use case

Leaving this checkbox unchecked initially provides a safer default action (i.e. performing a dry run). It would also better abide by the convention of requiring an additional click to perform a potentially dangerous operation.

External dependencies

No response

@jeremystretch jeremystretch added the type: feature A new feature or functionality label Jul 22, 2024
Copy link

linear bot commented Jul 22, 2024

BRA-6 Merging a branch should default to performing a dry run

Plugin Version

v0.2.0

Proposed functionality

The "merge branch" confirmation dialog (pictured below) currently commits by default.

screenshot

This FR proposes rendering this checkbox as unchecked initially.

Use case

Leaving this checkbox unchecked initially provides a safer default action (i.e. performing a dry run). It would also better abide by the convention of requiring an additional click to perform a potentially dangerous operation.

External dependencies

No response

@mrmrcoleman
Copy link

"Commit" may have confusing connotations in this context. "Dry Run" with reversed logic would be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants