Redis sentinel #1130
Closed
Redis sentinel #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagur87
force-pushed
the
redis-sentinel
branch
2 times, most recently
from
2a672b9 to
1d1d90f
Compare
this allows setting of the redis sentinel settings defined here: https://demo.netbox.dev/static/docs/configuration/required-settings/#using-redis-sentinel
tagur87
force-pushed
the
redis-sentinel
branch
from
1d1d90f to
5967295
Compare
|
Thanks for fixing that @tobiasge - I am double checking what I submitted works as expected. I will put as draft for now. |
|
Having an issue getting the SENTINELS variable to work as expected, since it's tuples in an array... |
3 tasks
|
Addressed in #1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Add Redis Sentinel Support to the netbox-docker image. Allowing setting of the values defined here:
https://demo.netbox.dev/static/docs/configuration/required-settings/#using-redis-sentinel
Contrast to Current Behavior
Can only set normal redis settings in current image.
Discussion: Benefits and Drawbacks
Redis sentinel is the high availability redis reccomended by netbox in the docs, and is supported. The container should support it too.
Changes to the Wiki
Maybe updating docs with values supported?
Proposed Release Note Entry
Double Check
developbranch.