Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: improve anki and foliate & add new profiles #6580

Closed
wants to merge 3 commits into from

Conversation

amano-kenji
Copy link
Contributor

@amano-kenji amano-kenji commented Dec 26, 2024

On gentoo linux, there is /usr/bin/foliate instead of /usr/bin/com.github.johnfactotum.Foliate

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many unrelated changes in the same PR, which makes review harder.

Split the changes into more PRs (this PR can be the anki one):

  • profiles: anki: fix dark mode detection & misc changes
  • profiles: foliate: add foliate to private-bin
  • New profile: aria2c/aria2rpc
  • New profile: hledger/hledger-ui
  • New profile: cryptonote-wallet-cli / monero-wallet-cli

Unless there is something in common about some of these, they should probably
also get 1 PR each:

  • New profile: buku
  • New profile: ncmpcpp
  • New profile: nsxiv
  • New profile: pyradio
  • New profile: tremc

As for a basic overall review:

  • The new profiles are missing the description and the rest of the comments
    that go before quiet (see profile.template /
    redirect_alias-profile.template)
  • The new profiles are missing the # Allow ... comment that goes before each
    include allow- entry (see profile.template)
  • Add notpm to the new profiles if they do not use TPM devices (which
    probably applies to all of them except for maybe the crypto ones) (see
    profile.template)

Also, add links to the homepage (or source code) of each program in the commit
message and PR. For example, I have no idea what buku and tremc are
supposed to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants