Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future incompatibility of fs_extra v1.2.0 and wasmparser v0.78.2 #8723

Open
jakmeier opened this issue Mar 14, 2023 · 1 comment
Open

Future incompatibility of fs_extra v1.2.0 and wasmparser v0.78.2 #8723

jakmeier opened this issue Mar 14, 2023 · 1 comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@jakmeier
Copy link
Contributor

With Rust 1.68.0 (which we use since #8721) there is a future compatibility warning.

warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.2.0, wasmer-singlepass-backend-near v0.18.1, wasmparser v0.78.2

This is the relevant change: rust-lang/rust#103418

I think fs_extra we could update without too much trouble.

But for wasmparser, I think we want the exact version to be sure we have no behavioral changes for older protocol version. I guess maybe we want to ask for a 0.78.3?

@jakmeier jakmeier added the C-housekeeping Category: Refactoring, cleanups, code quality label Mar 14, 2023
@nagisa
Copy link
Collaborator

nagisa commented Mar 14, 2023

I don't think it is critical that we act on this right away – future compatibility lints tend to stick around as warnings for quite a while before they become an error.

Knowing wasmparser's approach to maintenance, I strongly doubt they'll be onboard with releasing patch versions for past releases. I don't think it is reasonable for us to expect them to, either. After all, if there were 100 projects using random, locked versions of wasmparser, requests for patch versions like these would be a never-ending deluge. Not to mention, that were there another compatibility lint in the future, maintainers would have to suffer through an encore such an effort.

Two options I see that would fix this properly:

  1. Vendor the affected libraries and adjust;
  2. (Proper) limited replayability.

@jakmeier jakmeier mentioned this issue Mar 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

No branches or pull requests

2 participants