-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 1.3.0 #283
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all tests to use test-data package
fix missing schemas directory in hello-world task
**Summary:** Adds support for testing output of activities in workflow tests Addresses https://bugs.earthdata.nasa.gov/browse/CUMULUS-436 ## Changes * Replaces `integration-tests/lambda.js` with `integration-tests/sfnStep.js` and removes many reference to `lambda` * `sfnStep.js` includes `LambdaStep` and `ActivityStep` classes which inherit from `SfnStep` * Update CHANGELOG * Update exports from `integration-tests/index.js` ## Test Plan - [x] N/A Unit tests - [x] Integration tests passing (see nasa/cumulus-integration-tests#10) - [x] Updated CHANGELOG Reviewers: @sethvincent @yjpa7145 @laurenfrederick
abarciauskas-bgse
requested review from
laurenfrederick,
scisco and
marchuffnagle
March 30, 2018 13:58
laurenfrederick
previously approved these changes
Mar 30, 2018
closing and opening again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version 1.3.0
Includes a bunch of changes from master since release was out of date with master.
To resolve conflicts, I merged release into
release-version-v1.3.0
, fixed conflicts, and then mergedrelease-version-v1.3.0
intorelease-version-1.3.0
. There's no reason I did it that way as opposed to merging release directly intorelease-version-1.3.0
and resolving conflicts, the outcome should be the same. To resolve conflicts I picked the master version of a file over the release version in every case.