Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add cargo-deny #810

Merged
merged 2 commits into from
Mar 3, 2023
Merged

ci: Add cargo-deny #810

merged 2 commits into from
Mar 3, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Mar 3, 2023

This is a minimal cargo deny config which should not give us too many
issues. Let's see how this works in practice.

I just accepted all the currently used licenses, did not vet them.

flub added 2 commits March 3, 2023 12:48
This is a minimal cargo deny config which should not give us too many
issues.  Let's see how this works in practice.
@@ -0,0 +1,21 @@
[bans]
multiple-versions = "allow"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option is to list them something like this: /~https://github.com/deltachat/deltachat-core-rust/blob/c38ae31f3198fd56b01d7323cd8c7075c812db26/deny.toml#L14-L36

I don't think this is really worth it unless we really made an effort to remove dups. Which I don't think we've done yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff, yeah no need for that complexity, just allow multiple versions for now

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@flub flub merged commit 96bb61b into main Mar 3, 2023
@flub flub deleted the flub/cargo-deny branch March 3, 2023 13:54
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
This is a minimal cargo deny config which should not give us too many
issues.  Let's see how this works in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants