tests(iroh-net): Make dht_discovery_smoke test less flaky #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test had a hardcoded sleep(1) in there, which is a recipe for flaky tests on CI. Write this more defensively.
dignifiedquire
approved these changes
Nov 4, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2884/docs/iroh/ Last updated: 2024-11-04T10:46:56Z |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
github actions meltdown, let's try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test had a hardcoded sleep(1) in there, which is a recipe for
flaky tests on CI. Write this more defensively.
Breaking Changes
Notes & open questions
I'm kind of tempted to also remove the flaky marker, but who knows.
Change checklist