refactor(iroh)!: Remove gossip rpc types #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they live in iroh-gossip now under a feature flag
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2834/docs/iroh/ Last updated: 2024-10-30T09:10:04Z |
|
fun merge conflicts are fun.. |
# Conflicts: # Cargo.lock # Cargo.toml # iroh/src/node/builder.rs # iroh/src/node/rpc.rs # iroh/src/rpc_protocol/gossip.rs
rklaehn
force-pushed
the
move-rpc-types
branch
from
2d5e9b3 to
4da1d36
Compare
dignifiedquire
approved these changes
Oct 29, 2024
|
still some ci issues, otherwise lgtm |
rklaehn
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Remove gossip rpc types. They live in iroh-gossip now under a feature flag. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions note: updates to quic-rpc 0.13 ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove gossip rpc types. They live in iroh-gossip now under a feature flag.
Breaking Changes
Notes & open questions
note: updates to quic-rpc 0.13
Change checklist