tests(iroh): Mark test_blob_delete_mem as flaky #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only observed on windows, probably because this machine is always slower and triggers some race condition easier. We can change this to be flaky everywhere if we notice it happening on other platforms too. See #2783.
flub
requested review from
dignifiedquire,
matheus23,
Arqu,
ramfox and
divagant-martian
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2784/docs/iroh/ Last updated: 2024-10-04T08:45:41Z |
Arqu
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only observed on windows, probably because this machine is always
slower and triggers some race condition easier. We can change this to
be flaky everywhere if we notice it happening on other platforms too.
See #2783.
Breaking Changes
Notes & open questions
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] All breaking changes documented.