-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh): disable docs by default #2748
Conversation
f45698d
to
4a3caff
Compare
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2748/docs/iroh/ Last updated: 2024-09-30T08:37:12Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iroh/examples/client.rs
needs to be updated too
## Breaking Changes - removed: `iroh::node::Builder::disable_docs` - added: `iroh::node::Builder::enable_docs` - by default `iroh::node::Node::memory` & `persistent` have docs disabled
8f4ee51
to
3f2bd91
Compare
Breaking Changes
iroh::node::Builder::disable_docs
iroh::node::Builder::enable_docs
iroh::node::Node::memory
&persistent
have docs disabled