fix(iroh-blobs): preserve tracing subscriber in the LocalPool #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves the tracing subscriber that is installed in the current thread when the LocalPool is created. It then installs it into every thread managed by the pool, ensuring that tracing output from the pool is preserved. Maybe this should be configurable, though since this is just an internal tool for us I think we're fine just always having this behaviour. Fixes #2589
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2735/docs/iroh/ Last updated: 2024-09-17T11:08:59Z |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This preserves the tracing subscriber that is installed in the current
thread when the LocalPool is created. It then installs it into every
thread managed by the pool, ensuring that tracing output from the pool
is preserved.
Breaking Changes
Why is this even pub? But fine:
iroh_blobs::util::local_pool::LocalPoolwill now install the tracingsubscriber of the thread creating the pool, into each thread managed
by the pool. Practically this should not break any code already
managing their tracing subscribers either manually inside tasks or by
setting a global subscriber before creating the pool. But if you
really liked the behaviour of swallowing the logs on doing this it's a
breaking change.
Notes & open questions
Maybe this should be configurable, though since this is just an
internal tool for us I think we're fine just always having this
behaviour.
Fixes #2577
Replaces #2589
Change checklist