tests(iroh-cli): remove flaky mark from 5 tests and improve logs #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
reviewed
Jul 29, 2024
matheus23
approved these changes
Jul 29, 2024
divagant-martian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have not seen these tests fail for at least the past two weeks. I think they might no longer be flaky. I suspect much of the flakiness came from quinn's logging errors on shutdown, which no longer happens.
Breaking Changes
n/a
Notes & open questions
n/a
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.