refactor(iroh-blobs)!: implement some collection related things on the client side #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to reduce the rpc api
rklaehn
force-pushed
the
remove-collection-rpc
branch
from
a8534ef to
f32c2a5
Compare
iroh/src/client/blobs.rs
Outdated
|
|
||
| async fn list_collections_impl(&self, co: &Co<Result<CollectionInfo>>) -> Result<()> { | ||
| let tags = self.tags_client(); | ||
| let mut tags = tags.list().await?; |
There was a problem hiding this comment.
what about the filtering I mentioned on the other PR?
There was a problem hiding this comment.
My opinion is that we don't need it since you should not have that many tags. But we can add it.
There was a problem hiding this comment.
don't you end up with a lot of tags through documents?
There was a problem hiding this comment.
documents don't use tags as of now. they just inject a set of hashes to be left alone.
There was a problem hiding this comment.
they just inject a set of hashes to be left alone.
wait, how are they marking them as such then? 😅
There was a problem hiding this comment.
there is just a hook where you can feed it hashes...
In case somebody makes a million tags for stuff...
dignifiedquire
approved these changes
Jun 6, 2024
dignifiedquire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A collection is just one particular way to use a hashseq, so it feels a bit weird to have it baked in to the iroh node. With this we can move some of it into the client.
This is a part of #2272 . We can make more similar changes once we have the batch API #2339 .
Breaking Changes
Notes & open questions
Note: I closed #2272 because half of the changes in that PR are here, the other half will be part of the batch PR, and moving collections into iroh I am not convinced of yet...
Change checklist