fix: ci release builds #1988
Merged
fix: ci release builds #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ jobs: | |||
| env: | |||
| # Using self-hosted runners so use local cache for sccache and | |||
| # not SCCACHE_GHA_ENABLED. | |||
| RUSTC_WRAPPER: "sccache" | |||
| # RUSTC_WRAPPER: "sccache" | |||
There was a problem hiding this comment.
Cause the net benefit in this case is 0 and it would take me more time to make it work for windows.
Windows is not set up the same way so it starts complaining. Instead of doing a custom unset for windows or separate job, simply disabling it works as well.
These are jobs that are only rarely run manually and on tagged releases. They run with a different build profile so those caches we have from PRs are worth nothing in this case, might even be net negative where it pushes out some of those deps. By the time we do a follow up release, the deps are incredibly stale and most likely pushed out due to storage limits.
dignifiedquire
approved these changes
Feb 1, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description After the initial merge of n0-computer#1987 made some fixes. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description After the initial merge of #1987 made some fixes. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the initial merge of #1987 made some fixes.
Notes & open questions
Change checklist