chore(ci): add name to tests step #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Jan 8, 2024
Arqu
force-pushed
the
arqu/named_ci_step
branch
from
5a7f9fc to
5a3e09c
Compare
flub
reviewed
Jan 8, 2024
| @@ -22,6 +22,7 @@ env: | |||
|
|
|||
| jobs: | |||
| tests: | |||
| name: CI Test Suite | |||
There was a problem hiding this comment.
fwiw since this is used directly in the UI the horizontal space matters. I'd have made it tests to keep the same.
There was a problem hiding this comment.
fwiw since this is used directly in the UI the horizontal space matters. I'd have made it
teststo keep the same.
Agree, I just took something else as it overlaps with test / Tests and GH UI is confusing around these. I'll make an issue and revise on another pass.
There was a problem hiding this comment.
ah yeah. that branch protection UI is pretty rubbish too :(
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description Seems like the lack of job name makes it invisible on the branch protections, hence can't make the step required for the nested runs. Raw `Tests` job is available. This is just theory for now. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Seems like the lack of job name makes it invisible on the branch protections, hence can't make the step required for the nested runs. Raw `Tests` job is available. This is just theory for now. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like the lack of job name makes it invisible on the branch protections, hence can't make the step required for the nested runs. Raw
Testsjob is available. This is just theory for now.Notes & open questions
Change checklist