Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop temp tag after doc insert #1810

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: drop temp tag after doc insert #1810

merged 1 commit into from
Nov 15, 2023

Conversation

Frando
Copy link
Member

@Frando Frando commented Nov 15, 2023

Description

When importing files into docs, the temp tag should only be dropped after the hash was inserted into the doc. Otherwise gc could potentially delete the blob if hitting in between the tag drop and the completion of the doc insert.

Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! thank you!!!!

@Frando Frando enabled auto-merge November 15, 2023 19:19
@Frando Frando added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit a608fe8 Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants