feat: add Doc::import_file and Doc::export_file
#1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
reviewed
Nov 10, 2023
ramfox
force-pushed
the
doc_import_export
branch
from
623b879 to
c66a993
Compare
ramfox
force-pushed
the
doc_import_export
branch
from
c66a993 to
273c68e
Compare
ramfox
commented
Nov 12, 2023
ramfox
commented
Nov 12, 2023
ramfox
force-pushed
the
doc_import_export
branch
from
8e37ca6 to
77959e4
Compare
…e 3 pr reviews ago...>:(
ramfox
force-pushed
the
doc_import_export
branch
from
ea0d488 to
372c415
Compare
dignifiedquire
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1781
canonicalize_path:
There is now a
canonicalized_path_to_stringmethod that takes a path (that it expects to be canonicalized already) and turns it into a string.What was previously
canonicalize_pathis now renamed torelative_canonicalized_path_to_string, and callscanonicalized_path_to_string, with themust_be_relativeparam set totrue