feat(ci): CI improvements #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
force-pushed
the
arqu/ci_goodies
branch
3 times, most recently
from
3ff6d58 to
281e949
Compare
Arqu
force-pushed
the
arqu/ci_goodies
branch
4 times, most recently
from
911e65f to
5746af5
Compare
dignifiedquire
approved these changes
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
divagant-martian
pushed a commit
to divagant-martian/iroh
that referenced
this pull request
Oct 31, 2023
## Description 😢 this does add ~3 min to the existing 7min of linux runs, but at least it properly checks all crates now. Closes n0-computer#1716 You can now click on re run job and in the bottom of the prompt you can check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim --debug` for the appropriate tests to get full logging output. <img width="640" alt="Screenshot 2023-10-26 at 12 57 52" src="/~https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25"> <img width="640" alt="Screenshot 2023-10-26 at 12 58 05" src="/~https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9"> Closes n0-computer#1717 Linker changes are still up for debate Closes n0-computer#1423 We need to maintain the crates list, but shouldn't be too hard. Managed to pull it out into a single var. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant. --------- Co-authored-by: Friedel Ziegelmayer <me@dignifiedquire.com>
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description 😢 this does add ~3 min to the existing 7min of linux runs, but at least it properly checks all crates now. Closes #1716 You can now click on re run job and in the bottom of the prompt you can check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim --debug` for the appropriate tests to get full logging output. <img width="640" alt="Screenshot 2023-10-26 at 12 57 52" src="/~https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25"> <img width="640" alt="Screenshot 2023-10-26 at 12 58 05" src="/~https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9"> Closes #1717 Linker changes are still up for debate Closes #1423 We need to maintain the crates list, but shouldn't be too hard. Managed to pull it out into a single var. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant. --------- Co-authored-by: Friedel Ziegelmayer <me@dignifiedquire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
😢 this does add ~3 min to the existing 7min of linux runs, but at least it properly checks all crates now.
Closes #1716
You can now click on re run job and in the bottom of the prompt you can check
enable debug loggingto run withRUST_LOG=DEBUG&netsim --debugfor the appropriate tests to get full logging output.Closes #1717
Linker changes are still up for debate
Closes #1423
We need to maintain the crates list, but shouldn't be too hard. Managed to pull it out into a single var.
Notes & open questions
Change checklist