Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli,console): default to 'hash' mode for the keys command #1617

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(cli,console): default to 'hash' mode for the keys command #1617

merged 1 commit into from
Oct 11, 2023

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 11, 2023 •
edited
Loading

Description

The purpose of the doc keys command is to list keys. Having a default of auto that shows content, which makes the output unreadable from a "fast review of the keys in this doc" use case:
Screenshot 2023-10-11 at 1 20 19 PM

one default change keeps both the option, and makes the output useful again:

Screenshot 2023-10-11 at 1 22 26 PM

This leaves doc get untouched, which should absolutely keep the auto default.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@b5 b5 requested a review from divagant-martian October 11, 2023 17:22
@b5 b5 added this to the v0.7.0 milestone Oct 11, 2023
divagant-martian
divagant-martian approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any makes sense depending on use case so I don't think there is a perfect solution 🤷‍♀️ lgtm
in the future there might be interest on doing something similar with watch, which has no selection right now

@b5 b5 enabled auto-merge October 11, 2023 17:28
@b5 b5 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit c3571e1 Oct 11, 2023
@dignifiedquire dignifiedquire deleted the b5/fix_doc_keys_showing_content branch November 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@b5 @divagant-martian