Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(iroh-sync): fix test_content_hashes_iterator_memory #1565

Merged
merged 1 commit into from
Oct 3, 2023
Merged

test(iroh-sync): fix test_content_hashes_iterator_memory #1565

merged 1 commit into from
Oct 3, 2023

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Oct 3, 2023 •
edited
Loading

Description

the content of this test is the same as test_basics_memory so it;s doing a duplicated test scenario. Name suggests this is what should be here instead

Notes & open questions

na

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

Frando
Frando approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Frando Frando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks for catching this

@Frando Frando added this pull request to the merge queue Oct 3, 2023
Merged via the queue into n0-computer:main with commit 07fa983 Oct 3, 2023
@b5 b5 added this to the v0.7.0 milestone Oct 10, 2023
@divagant-martian divagant-martian deleted the fix-sync-mem-test branch December 10, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frando Frando Frando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@divagant-martian @Frando @b5