feat(iroh-net): persist known peer info #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
3 tasks
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
## Description - Adds a `AddrInfo` that contains the addressing information of peers. This is necessary as it's own type since it's serialized both in gossip and in #1488 - Renames `NodeAddr` to `PeerData` (better name suggestions are well received) this helps consolidate the "peer" terminology already present throughout gossip, sync, downloader, and many other places - Use this type in different parts of the code. Some other types that can be replaced by this are left to #1493 ## Notes & open questions This applies the suggestion of doing `connect` using the full type. It's debatable if this is better than `connect(PublicKey, AddrInfo)` but both are imo an improvement over the current way since the idea if "what does iroh need to connect to a peer" is now fully described in a type ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [ ] Tests if relevant.
Frando
reviewed
Sep 25, 2023
| msock_sender: mpsc::Sender<ActorMessage>, | ||
| ) -> anyhow::Result<Self> { | ||
| let mut me = PeerMap::default(); | ||
| let contents = std::fs::read(path)?; |
There was a problem hiding this comment.
We could read in chunks here. However the file would need to get really big for this to be an issue. A PeerAddr will take less than 100 bytes even with a few socket addresses. So if you store 10.000 peers that'd do a ~1MB allocation here. Could make it async then too. However as this is only run once when binding the socket it won't matter much in practice I'd guess.
I think it's fine to keep as-is now, and we could move to chunked reading easily in a follow-up.
Frando
approved these changes
Sep 25, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
## Description Adds an e2e test for #1488 ## Notes & open questions na ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [x] Tests if relevant.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Rough list of changes - add an option to the `MagicEndpointBuilder` to set the path in which peers are saved. This is used to read peers on start up and store them on an interval and on shutdown. - add `KnownPeers` to ease serializing and deserializing peer info - move the logic of `add_known_addr` to the `PeerMap` to facilitate instantiating from a known peer list - Add an `IrohPath` for the peers. - Add an option to the `Node`s builder to set the path, passed down to the endpoint. - For serialization it makes sense to have an object modelling the peer addressing info. This is the `AddrInfo`, which now replaces the custom `IrohInfo` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rough list of changes
MagicEndpointBuilderto set the path in which peers are saved. This is used to read peers on start up and store them on an interval and on shutdown.KnownPeersto ease serializing and deserializing peer infoadd_known_addrto thePeerMapto facilitate instantiating from a known peer listIrohPathfor the peers.Nodes builder to set the path, passed down to the endpoint.AddrInfo, which now replaces the customIrohInfoNotes & open questions
Change checklist