refactor(iroh-net): remove unused expired
field from Endpoint
#1484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This field is unused and models a concept from tailscale that we don't have. This doesn't mean the peer's info is stale, or that it was last seen long ago, it means that the peer's public key expired based on an explicit
KeyExpiry *time.Time
.From their docs
In tailscale the
Expired
is only set by aExpiryManager
based on that timestamp, from local computation; and only when theNetworkMap
has not updated it based on aMapResponse
requested to the server. We have none of this concepts.If we want to define that a peer/endpoint expired, we should do it on our terms later on if the need arises.
Notes & open questions
none
Change checklist