Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh-net): remove unused expired field from Endpoint #1484

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Sep 17, 2023

Description

This field is unused and models a concept from tailscale that we don't have. This doesn't mean the peer's info is stale, or that it was last seen long ago, it means that the peer's public key expired based on an explicit KeyExpiry *time.Time.

From their docs

// Expired is whether this node's key has expired. Control may send
// this; clients are only allowed to set this from false to true. On
// the client, this is calculated client-side based on a timestamp sent
// from control, to avoid clock skew issues.

In tailscale the Expired is only set by a ExpiryManager based on that timestamp, from local computation; and only when the NetworkMap has not updated it based on a MapResponse requested to the server. We have none of this concepts.

If we want to define that a peer/endpoint expired, we should do it on our terms later on if the need arises.

Notes & open questions

none

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@divagant-martian divagant-martian added this pull request to the merge queue Sep 17, 2023
Merged via the queue into n0-computer:main with commit f2f3ead Sep 17, 2023
@divagant-martian divagant-martian deleted the remove-expired-field-from-endpoint branch September 17, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants