Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(iroh-net): Removed unused stun_test_ip field from DerpNode #1450

Merged
merged 1 commit into from
Sep 4, 2023
Merged

test(iroh-net): Removed unused stun_test_ip field from DerpNode #1450

merged 1 commit into from
Sep 4, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Sep 4, 2023

Description

The DerpNode had a field to override the IP address of the STUN server
in testing scenarios. However we do not use this, it is always the
same address as the derp server, just like in production.

Removing this removes some code complexity.

Notes & open questions

I believe this was an unused left-over from the wireguard conversion.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@flub
test(iroh-net): Removed unused stun_test_ip field from DerpNode
adccad3 
The DerpNode had a field to override the IP address of the STUN server
in testing scenarios.  However we do not use this, it is always the
same address as the derp server, just like in production.

Removing this removes some code complexity.
@flub flub enabled auto-merge September 4, 2023 13:34
rklaehn
rklaehn approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see a single place where it was set, so it seems removing it seems like the right thing to do...

@flub flub added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@flub flub added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit 4ef3611 Sep 4, 2023
@b5 b5 added this to the v0.6.0-alpha2 milestone Sep 5, 2023
@dignifiedquire dignifiedquire deleted the flub/no-stun-test-ip branch November 1, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rklaehn rklaehn rklaehn approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

@ramfox ramfox Awaiting requested review from ramfox

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.6.0-alpha.1
Development

Successfully merging this pull request may close these issues.
3 participants
@flub @rklaehn @b5