refactor(iroh-net): remove NetworkMap
#1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
refactor-netmap
branch
2 times, most recently
from
7004506 to
fdbf3d5
Compare
Frando
force-pushed
the
refactor-netmap
branch
from
fdbf3d5 to
b2eee3b
Compare
dignifiedquire
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While having another look at the code when thinking about #1440 I realized that the
NetworkMapis never used apart from serving as a source of entries for thePeerMap.So I removed it. Looks much simpler now, and tests passed for me locally. Not sure if I haven't missed something.
Notes & open questions
peer_map. This is already the case before this PR if I'm not missing something, because we never removed entries from theNetworkMap, and only the latter would ever have triggered a removal of entries from thepeer_map.Change checklist