Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): ensure external contributors don't fail CI on report dumps #1304

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Jul 27, 2023

Description

Detects if we're running netsim from a fork and doesn't dump reports.
Closes #1297

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@Arqu Arqu self-assigned this Jul 27, 2023
@Arqu Arqu added the ci continous integration label Jul 27, 2023
@Arqu Arqu force-pushed the arqu/futzing_ci branch from 51c7df7 to 54aed24 Compare July 27, 2023 08:21
@Arqu Arqu changed the title WIP: ensure external contributors don't fail CI on report dumps chore(ci): ensure external contributors don't fail CI on report dumps Jul 27, 2023
@Arqu Arqu requested a review from flub July 27, 2023 08:43
@@ -246,7 +246,7 @@ jobs:

- name: test
run: cross test --all --target ${{ matrix.target }} -- --test-threads=12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new whitespace :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuked it :D

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that was easier than expected

@Arqu Arqu enabled auto-merge July 27, 2023 09:19
@Arqu Arqu added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 854c242 Jul 27, 2023
@Arqu Arqu deleted the arqu/futzing_ci branch July 27, 2023 09:51
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
…#1304)

* chore(ci): ensure forks don't run report dumps

* drop whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci continous integration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ci: make sure external contributors can get green CI
3 participants