chore: Enable CI on merge_group trigger #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for CI jobs to run in the merge queue. And if CI doesn't run in the merge queue it will never have green CI to merge.
dignifiedquire
approved these changes
Jul 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
* chore: Enable CI on merge_group trigger This is required for CI jobs to run in the merge queue. And if CI doesn't run in the merge queue it will never have green CI to merge. * report dumps for merge_group * introduce job timeouts for CI --------- Co-authored-by: Asmir Avdicevic <asmir.avdicevic64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is required for CI jobs to run in the merge queue. And if CI
doesn't run in the merge queue it will never have green CI to merge.
See docs for more info:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions
It also needs to update the netsim-custom code that extracts the commit hash.
Notes & open questions
Change checklist
Documentation updates if relevant.Tests if relevant.