fix(derp): Filter DNS results by address family #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try dialing the derper via both IPv4 and IPv6. However when the derper address is looked up via DNS we need to filter the DNS results for the corresponding address family otherwise we'll end up dialing the same derper twice on the same address.
dignifiedquire
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We try dialing the derper via both IPv4 and IPv6. However when the
derper address is looked up via DNS we need to filter the DNS results
for the corresponding address family otherwise we'll end up dialing
the same derper twice on the same address.
Notes & open questions
Tested by staring at logs. Can't really wish for more right now.
Change checklist