Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add explict parity acknowledgement on cert & verifier files, clarify codebase copyright is assigned to n0, inc. #1167

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

b5
Copy link
Member

@b5 b5 commented Jul 5, 2023

Two files in our codebase are largely pulled from libp2p-tls, and while both projects are MIT licensed, we should clarify and acknowledge that these two files originated from an MIT license Copy-written by Parity Technologies (UK), Ltd.

Shoutout to Parity who both originated this code and contributed it to the libp2p project, and the libp2p, team that has extended this code. Also thank you to @divagant-martian for realizing this was missing.

At the same time, I've also added "Copyright N0, INC", to clarify the entity this code has actually been assigned to

@b5 b5 self-assigned this Jul 5, 2023
LICENSE-MIT Outdated Show resolved Hide resolved
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not add the whole MIT license, there is no need for that (and it is super confusing).

Just a simple

// Based on <repo/file> originally licensed under MIT by Parity Technologies (UK) Ltd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this format, looks like a nice middle ground

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we all love github loopholes? lgtm

@divagant-martian divagant-martian merged commit 04c7247 into main Jul 5, 2023
@divagant-martian divagant-martian deleted the add_license_refs branch July 5, 2023 20:40
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
…larify codebase copyright is assigned to n0, inc. (#1167)

* chore: add explict parity acknowledgement on cert & verifier files

* um, it's not 2024

* give attribution in a less extreme way

---------

Co-authored-by: Diva M <divma@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants