Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iroh-net): expand use of default values #1160

Merged
merged 5 commits into from
Jul 5, 2023
Merged

refactor(iroh-net): expand use of default values #1160

merged 5 commits into from
Jul 5, 2023

Conversation

divagant-martian
Copy link
Contributor

No description provided.

dignifiedquire
dignifiedquire previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less magic strings and numbers, this is great

@dignifiedquire
Copy link
Contributor

looks like the ci failures are real

@divagant-martian
Copy link
Contributor Author

divagant-martian commented Jul 4, 2023 •
edited
Loading

checking (but surprised) oh yeah I fucked up. let me fix this

@divagant-martian divagant-martian merged commit 0905155 into n0-computer:main Jul 5, 2023
@divagant-martian divagant-martian deleted the default-code-improvements branch July 5, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divagant-martian @dignifiedquire