Skip to content

Commit

Permalink
test(iroh-net): Ignore MagicEndpoint test again (#1300)
Browse files Browse the repository at this point in the history
I have sufficient information for now to work on improving this.  No
point in keeping a known flaky test in CI for now.

Part of #1183
  • Loading branch information
flub authored Jul 26, 2023
1 parent af52b51 commit c6314ff
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions iroh-net/src/magic_endpoint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ impl MagicEndpoint {
pub async fn close(&self, error_code: VarInt, reason: &[u8]) -> anyhow::Result<()> {
self.endpoint.close(error_code, reason);
self.endpoint.wait_idle().await;
// TODO: Now wait-idle on msock!
self.msock.close().await?;
Ok(())
}
Expand Down Expand Up @@ -447,6 +448,7 @@ mod tests {

const TEST_ALPN: &[u8] = b"n0/iroh/test";

#[ignore]
#[tokio::test]
async fn magic_endpoint_connect_close() {
let _guard = setup_logging();
Expand Down Expand Up @@ -484,6 +486,7 @@ mod tests {
quinn::ConnectionError::LocallyClosed
))
);
info!("server test completed");
}
.instrument(info_span!("test-server")),
)
Expand Down Expand Up @@ -527,6 +530,7 @@ mod tests {

let res = conn.open_uni().await;
assert_eq!(res.unwrap_err(), expected_err);
info!("client test completed");
}
.instrument(info_span!("test-client")),
);
Expand Down

0 comments on commit c6314ff

Please sign in to comment.