-
Notifications
You must be signed in to change notification settings - Fork 184
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(metrics): labels need to be lowercase underscore format (#1574)
## Description The current metrics names/labels are not compatible with the OpenMetrics format and prometheus declines to ingest them. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
- Loading branch information
Showing
7 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,6 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"Iroh Gossip" | ||
"gossip" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,6 +140,6 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"Magicsock" | ||
"magicsock" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,6 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"Netcheck" | ||
"netcheck" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,6 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"Portmap" | ||
"portmap" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,6 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"iroh-sync" | ||
"iroh_sync" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ impl Default for Metrics { | |
|
||
impl Metric for Metrics { | ||
fn name() -> &'static str { | ||
"Iroh" | ||
"iroh" | ||
} | ||
} | ||
|
||
|