Skip to content

Commit

Permalink
chore(ci): Warn in our discord channel on failure (#2044)
Browse files Browse the repository at this point in the history
## Description

This is better than error, since flaky tests really are expected to be
flaky.  And we don't want to miss other errors in that channel which
are more important.

## Notes & open questions

Maybe warn is even a bit high, but all that matters is that we get
different colours in our channel.  If later we send more notifications
to that channel we can tweak the levels appropriately.

## Change checklist

- [x] Self-review.
  • Loading branch information
flub authored Feb 27, 2024
1 parent 5398479 commit 6f1e13f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/flaky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
uses: n0-computer/discord-webhook-notify@v1
if: ${{ env.TESTS_RESULT == 'failure' }}
with:
severity: error
severity: warn
details: |
Flaky tests failed again, why don't you go fix them?
See /~https://github.com/n0-computer/iroh/actions/workflows/flaky.yaml
Expand Down

0 comments on commit 6f1e13f

Please sign in to comment.