-
Notifications
You must be signed in to change notification settings - Fork 184
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(iroh)!: Eliminate the type parameter for the rpc service type (
#2405) ## Description Eliminate the type parameter for the rpc service type in the builder. We are going to need more type parameters if we want to make rpc generic and extendable, so we need to make some room... :-) ~~todo: needs new minor version of quic-rpc to make boxed(...) public~~ ## Breaking Changes - Builder loses the `E` type parameter - ProtocolBuilder loses the `E` type parameter - rpc_endpoint takes a `boxed::ServerEndpoint` ## Notes & open questions Note: we now require the user to box the rpc_endpoint if they want to do a custom one. But since that is most likely a non-mem version it should not have a performance impact. If you want a mem rpc controller, we already have that... ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
- Loading branch information
Showing
3 changed files
with
58 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters