Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prune some deps #8

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: prune some deps #8

merged 2 commits into from
Nov 15, 2024

Conversation

Arqu
Copy link
Contributor

@Arqu Arqu commented Nov 15, 2024

Description

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu self-assigned this Nov 15, 2024
@Arqu Arqu requested review from flub and dignifiedquire November 15, 2024 12:19
Copy link

github-actions bot commented Nov 15, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/8/docs/iroh_gossip/

Last updated: 2024-11-15T12:50:24Z

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mostly adds a duplicate thiserror dep and doesn't remove any?

@@ -131,7 +131,7 @@ dependencies = [
"nom",
"num-traits",
"rusticata-macros",
"thiserror",
"thiserror 1.0.69",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is adding a dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah gossip was mostly in the clear I just updated the lockfiles and aligned with iroh@main. That dep should go away at some point on it's own once the deps tree shakes it out.

@Arqu Arqu merged commit ba0f6b0 into main Nov 15, 2024
24 checks passed
@Arqu Arqu deleted the arqu/deps_war branch November 15, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants