Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break when an unused variant points at a non-existent file #90

Merged
merged 1 commit into from
May 24, 2020
Merged

Don't break when an unused variant points at a non-existent file #90

merged 1 commit into from
May 24, 2020

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou requested a review from Munter May 24, 2020 15:33
@papandreou papandreou self-assigned this May 24, 2020
@coveralls
Copy link

coveralls commented May 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 311

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.268%
Totals Coverage Status
Change from base Build 309: 0.03%
Covered Lines: 987
Relevant Lines: 1058
💛 - Coveralls

@Munter
Copy link
Owner

Munter commented May 24, 2020

Strange that I couldn't recreate that situation in the test myself. I had something that I think looked exactly like it locally that didn't work :/

Thanks!

@Munter Munter merged commit f2c4d4d into master May 24, 2020
@Munter Munter deleted the fix/notFoundUnusedVariants branch May 24, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Awaiting requested review from Munter

Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@papandreou @coveralls @Munter