fix: allow use of custom client authenticator types #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackHartley
commented
May 16, 2023
docs/resources/openid_client.md
Outdated
| @@ -53,7 +53,7 @@ resource "keycloak_openid_client" "openid_client" { | |||
| URIs for security. This client should be used for applications using the Implicit grant flow. | |||
| - `BEARER-ONLY` - Used for services that never initiate a login. This client will only allow bearer token requests. | |||
| - `client_secret` - (Optional) The secret for clients with an `access_type` of `CONFIDENTIAL` or `BEARER-ONLY`. This value is sensitive and should be treated with the same care as a password. If omitted, this will be generated by Keycloak. | |||
| - `client_authenticator_type` - (Optional) Defaults to `client-secret` The authenticator type for clients with an `access_type` of `CONFIDENTIAL` or `BEARER-ONLY`. Can be one of the following: | |||
| - `client_authenticator_type` - (Optional) Defaults to `client-secret`. The authenticator type for clients with an `access_type` of `CONFIDENTIAL` or `BEARER-ONLY`. The following types are available on an unmodified Keycloak server: | |||
There was a problem hiding this comment.
Suggestions appreciated
"unmodified" isn't as descriptive as I'd like. Has supporting Keycloak plugins been a concern in the past (and might there be documentation I can align with)?
There was a problem hiding this comment.
I'll change this to something like A default Keycloak installation will have the following available types
JackHartley
force-pushed
the
allow-custom-client-authenticator
branch
2 times, most recently
from
7868335 to
1b36e18
Compare
JackHartley
force-pushed
the
allow-custom-client-authenticator
branch
2 times, most recently
from
727fbb8 to
a36d505
Compare
JackHartley
force-pushed
the
allow-custom-client-authenticator
branch
from
a36d505 to
91597eb
Compare
|
Sorry for the long delay on this. I don't consider this a breaking change since it won't affect any existing configuration. I'll merge and release this today. |
mrparkers
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842.
I'm assuming this is considered a breaking change. Is there a recommended way to flag this?
I was reluctant to add an acceptance test for a fake custom client authenticator (dummy value) since it would break if Keycloak was changed to validate the authenticator in future.