Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource_authentication_bindings #668

Merged
merged 8 commits into from
May 4, 2022

Conversation

camjjack
Copy link
Contributor

Enable setting custom authentication flows to a realm created in the same run.

Closes #298

Credit to bruno-delfino1995 code referenced #298 (comment)

@mrparkers
Copy link
Contributor

Hey @camjjack, thanks for this PR. I ended up pushing a fix that's related to some changes I made earlier this week, so this should be in a mergable state now.

I was testing this locally and it looks like this resource is unfortunately fighting with some of the attributes within the keycloak_realm resource. For example, if you don't specify the browser_flow for the keycloak_realm resource and you use this resource to specify it instead, these two resources will fight with each other on each run of terraform apply.

I can continue to mess with this when I have some free time to find a solution. I think we'll have to update the Realm struct to turn those attributes into string pointers, so they aren't sent to Keycloak unless they're specified by the user.

@msvechla
Copy link

Any update on this? It looks like the fix with the string pointers has been applied. I would also be open to jump in if something still needs some work

@mrparkers
Copy link
Contributor

Unfortunately, it isn't quite done yet. I had a bit of time last month to push a few commits but I've been swamped lately and haven't had time since to revisit this.

When I left it, there was still some issues with the expected behavior for removing authentication flow assignment via this resource or the keycloak_realm resource. I might be able to put another few hours into this over the weekend so I could hopefully close this out and cut a release.

@mrparkers
Copy link
Contributor

@camjjack @msvechla I've gone ahead and made the required changes to get this in a mergable state. Thanks again @camjjack for all of your hard work on this!

@mrparkers mrparkers merged commit ef8aacc into keycloak:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign realm default flow not possible
3 participants