Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for configuring authentication OTP policy (#394) #585

Merged
merged 3 commits into from
Sep 15, 2021
Merged

feat: Support for configuring authentication OTP policy (#394) #585

merged 3 commits into from
Sep 15, 2021

Conversation

nolte
Copy link
Contributor

@nolte nolte commented Sep 5, 2021

Adding support for configuring authentication OTP policy of some Realm, will be fixed #394

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, overall this LGTM, just had one question

Default: 6,
Optional: true,
},
"initial_counter": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually see the setting for this in the latest three Keycloak versions. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Option is only visible if you use a OTP Type: Counter Based , for the Default Type, Time Based, you will got the field OTP Token Period ( period).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I just missed that then. Thanks for your help

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mrparkers mrparkers merged commit d5e549d into keycloak:master Sep 15, 2021
@nolte nolte deleted the feature/394-otp-policy branch September 15, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for configuring authentication OTP policy
2 participants