Fix attribute importer and user template mapper for Facebook/Google #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Photonios
force-pushed
the
idp-mapper-types-google-facebook
branch
from
0e43727 to
5f46c7a
Compare
GET /auth/admin/realms/<realm>/identity-provider/instances/google/mapper-types GET /auth/admin/realms/<realm>/identity-provider/instances/facebook/mapper-types Return the type of the user template mapper to be `oidc-username-idp-mapper`. Not `<provider id>-username-idp-mapper`.
GET /auth/admin/realms/<realm>/identity-provider/instances/google/mapper-types GET /auth/admin/realms/<realm>/identity-provider/instances/facebook/mapper-types Return the type of the user template mapper to be `<provider id>-user-attribute-mapper`. Not `<provider id>-user-attribute-idp-mapper`. The correct fields are also `jsonField` and `userAttribute`.
Photonios
force-pushed
the
idp-mapper-types-google-facebook
branch
from
5f46c7a to
8bdda7e
Compare
This is for the Google/Facebook mappers.
mrparkers
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keycloak_attribute_importer_identity_provider_mapperThis does not currently work for the Facebook and Google identity providers because of two reasons:
IdentityProviderMapperis<provider id>-user-attribute-idp-mapper, while it should be<provider id>-user-attribute-mapper.userAttributeandjsonField.keycloak_user_template_importer_identity_provider_mapperThis does not currently work for the Facebook and Google identity providers because of:
IdentityProviderMapperis<provider id>-username-idp-mapper, while it should beoidc-username-idp-mapper.The more correct fix for all of these would be to hit
/{realm}/identity-provider/instances/{alias}/mapper-typesto get a list of available mapper types and config fields and to select the right one based on the category.This short-cut makes it work till that work can be done. This if-else magic was already happening in the attribute importer resource.