-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field session_note to user session protocol mapper. This field ne… #365
Conversation
Huh, I swear this attribute in the protocol mapper used to be called "session note label", but it appears to have disappeared completely from the UI. I think it might have been silently renamed in one of the releases since I originally created this resource. What do you think about simply renaming the existing |
That's perfectly fine with me. I just kept the original session note label field because I didn't want to introduce unintended behaviour in Keycloak. It seems though that the value of the session note label is still stored in the database, when PUT or POST against the admin API but in the end I couldn't find out what it really does. |
…eds to be written additionally to session_note_label if the protocoll mapper is intended to work correctly, e.g. an Apache mod_auth_openidc client
I removed the session-note-label field from the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…ol_mapper, deprecate session_note_label attribute (keycloak#365)
Add field session_note to user session protocol mapper. This field needs to be written additionally to session_note_label if the protocol mapper is intended to work correctly, e.g. an Apache mod_auth_openidc client.