add userClientRole protocol mapper #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrutsaert
reviewed
May 27, 2020
| - `name` - (Required) The display name of this protocol mapper in the GUI. | ||
| - `claim_name` - (Required) The name of the claim to insert into a token. | ||
| - `claim_value_type` - (Optional) The claim type used when serializing JSON tokens. Can be one of `String`, `JSON`, `long`, `int`, or `boolean`. Defaults to `String`. | ||
| - `multivalued` - (Optional) Indicates if attribute supports multiple values. If true, then the list of all values of this attribute will be set as claim. If false, then just first value will be set as claim. Defaults to `true`. |
There was a problem hiding this comment.
The default in your code is false (I only know because there was pr to fix this on user realm role protocol mapper)
|
As mrparkers already looked at this (in #287) and as all seems good to me, |
mrparkers
approved these changes
May 27, 2020
|
Thanks for your feedbacks @tomrutsaert @mrparkers . Doc fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mrparkers , i closed previous PR #287 and clean commits before submitting this one.