Fixed handling of Default Client Scope for deleted clients (#226) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a client with a Default Client Scope. After I deleted the client, "terraform refresh" crashed.
This should be handled better.
Terraform actually refreshed the client long before it tried to refresh the Default Client Scope so it should be aware that it makes no sense to query for its Default Client Scopes.
That knowledge seems even not necessary if it defaults to just delete the current state of the Default Client Scope if the server answers with a HTTP 404 NOT FOUND.
I saw this behavour in resource_keycloak_group_membership.go where
handleNotFoundError()was called in that situation.Doing exactly so in resource_keycloak_openid_client_default_scope.go works fine for me with Keycloak 8.0.1.