Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable planning_scene_monitor.test.py test after diagnosing its flaky bring-up #2821

Open
EzraBrooks opened this issue Apr 30, 2024 · 3 comments
Labels
persistent Allows issues to remain open without automatic stalling and closing.

Comments

@EzraBrooks
Copy link
Member

This is failing across a number of branches. It may be a latency issue, esp. if that latency is induced specifically by the slowness of GitHub Actions runners, since we can't seem to reproduce this locally.

Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jun 17, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Jun 17, 2024
@sea-bass
Copy link
Contributor

sea-bass commented Nov 17, 2024

It appears this test is still enabled on the humble branch and very much flaky.

Rather than disabling it there, I wonder if it's a good time to give this a look.

Whenever I see flaky tests like this, I tend to pull out the old stress command to recreate the CI runners. It's paid off a few times.

@sea-bass
Copy link
Contributor

sea-bass commented Nov 23, 2024

Note that I've re-enabled the test after adding a 1 second sleep after kicking off the executor thread in the fixture setup, which somehow resolves a race condition and seems to make the test pass consistently (I ran them many times in CI).

#3124

I would not consider this issue closed until the real root cause is resolved, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

3 participants